I would like to nominate Martin Weber as a new CDT committer. Martin has extensive knowledge of the CDT build system as the long time author and maintainer of cmake4eclipse. He has been putting his knowledge and skill to good use in CDT by contributing and modernizing parts of cmake4eclipse. He has provided improvements to the overall releng experience as well. Below is a list of his already merged commits and you can see his contributions on the mailing lists with http://google.com/search?q=%22fifteenknots505%22%20site:www.eclipse.org… (20+ separate threads) and gerrits he owns with https://git.eclipse.org/r/#/q/owner:fifteenknots505%2540gmail.com (25 results at time of nomination)
$ git log --author=fifteenknots --oneline
040b1351e8 Bug 559674: Internationalization of UI texts
169c74728f Bug 559674: adjust plugin references to point to new plugin name
48961a341b Bug 559674: fix failing tests
b37b7187ae Bug 559674: move API classes for consumers of this to top-level package
d804c5ae75 Bug 559674: make class final
cfe6a49692 Bug 559674: Improve doc and javadoc
aa377d40c2 Bug 559674: eliminate 'lsp' (language settings provider)
3b8551a14a Bug 559674: move 'contribute more implementations API' to package participant
488cc91689 Bug 559674: Fix: New console allocated even if one is given
2abe8b5f31 Bug 559674: Use OptionMetadata based implementation for preference access
d13343cda9 Bug 559674: Migrating from a ILanguageSettingsProvider implementation to IIndexerInfoConsumer (6/6)
e9d6747a74 Bug 559674: Migrating from a ILanguageSettingsProvider implementation to IIndexerInfoConsumer (5/6)
636691a404 Bug 559674: Migrating from a ILanguageSettingsProvider implementation to IIndexerInfoConsumer (4/6)
f80235d0e0 Bug 559674: Migrating from a ILanguageSettingsProvider implementation to IIndexerInfoConsumer (3/6)
9bf029721a Bug 559674: Migrating from a ILanguageSettingsProvider implementation to IIndexerInfoConsumer (2)
fc7e62940f Bug 559674: Migrating from a ILanguageSettingsProvider implementation to IIndexerInfoConsumer (1)
268903ba01 Bug 561318: Recursively delete files without running out of handles
2359724b52 Bug 559674: initial import from cmake4eclipse
| Voter | Vote | Comments |
|---|---|---|
| Jonah Graham | +1 | +1 implied by nomination |
| Marco Stornelli | +1 | I think it would be great to have Martin in the team. |
| Alexander Fedorov | +1 | Martin has done a great job of adapting his cmake contribution to Eclipse CDT standards. His code adds a lot of value for Eclipse CDT functionality and the quality of his work is above the medium that we have in our source base at the moment. Moreover, he is continuously improving the code and he is very responsive to all the review comments. |
| Alexander Kurtakov | +1 | Welcome Martin! |
| Thomas Corbat | +1 | Great work! |
| John Dallaway | +1 | |
| Marc-André Laperle | +1 |
PMC Approval
- Alexander Kurtakov (+1) Welcome!