Election for David Thompson as Committer on Eclipse JDT LS

Nominee
Project
Role Type
Criteria

David has been a regular contributor to the JDT land, applied to JDT.

On JDT-LS itself, he's provided some useful patches:
901ad45d47b8aa16acb5c3fcabdeee9f2252e801 Do not show references for unnamed class
40611dc3e419821aa76f58c54314a7d23e9a059a Check if gradle upgrade is cancelled
a59f4a1807558605f46d7ec1c5716dcaa4017293 Fix build status badge
34a63d0b506d36395afe2d015f262a579629e821 New delegate command to handle paste events
7c7a064c45754f1c644f028181f878c3ac9f4481 QuickFix for annotation missing attributes
c9a2d051fc084f2d658c7326956c9698d12bee46 Add clean ups (configurable fixes that are run on save)

On the JDT Core Incubator (targetting unnamed classes support, and also Javac compiler backend, on the dom-with-javac branch), he has authored the following commits
0460afe73f16aca84f2faa7289050d5ca656e209 Implement all methods in JavacTypeBinding and JavacMethodBinding
b53fa9a387423a01a99d2d851f674e19f528036a Implement some methods in JavacMethodBinding
6959921fcfe6cc8732ccd3d5d55c442d63858963 Allow parsing document with just identifier (#177)
fd4a49957d178196ef65204f837d9a711467b6f3 Some conversion fixes
61fbe37df64ab5ac54c61a59558869bc40cb6613 Prevent StackOverflow when parsing working copy of module declaration
151278cad84e3456cc72006f51799cc24cad3d94 Rename "UnnamedClass" to "ImplicitlyDeclaredClass"
696ceaf3c4031c4ad6f88eb9ed6620e92be35c21 Provide an API to check if an IType is an implicitly declared class.
9b2ac9f6825ff14fc03a40935116c125d4f46714 Fix `Util.getSignature()` for `QualifiedType`
d0c6a4d0decb1fbf5f28bb9d11bcc9bea07913c3 Fix RecordPattern generation for standalone instanceof (#2016)
b4875fc5369bef8a0effde237a1890ea74ccf2b8 Unnamed patterns and varibles (JEP 443) without pattern lists (#1517)
and additionally to this list, he was also strongly involved in the bigger commit '627940f9c525de3962ae6e6a5f2a1a61b380a1c8 Switch to make some operations rely on DOM instead of ECJ'

David is continuously helping to improve the Java support in JDT-LS in general and is committed to continue working deeply in the Javac integration.

Through all those contributions, David has demonstrated good community interaction skills, participating in fruitful project discussions, and the authored code meets the expected code quality of the project.

For those reason, I think we should make David a committer on the project to make him more productive and to allow the project to benefit even more from its contributions.

Nominated by
Date
-
Status
This election has been approved by the PMC.
Voter Vote Comments
Mickael Istria +1 +1 implied by nomination
Fred Bricon +1 Welcome David!
Hope Hadfield +1
Snjezana Peco +1
Roland Grunberg +1 Welcome!

PMC Approval

  • Alexander Kurtakov (+1) Welcome!