I would like to nominate Patrick as WB committer.
Patrick develops for his company a huge RCP application in which they also have WB integrated.
So far he contributed three improvements to WB. See below for details.
He also has three more PR pending.
commit 7ce471952756cadc4fd6d2da3d94f18c04f1a6ab (HEAD -> master, origin/master, origin/HEAD)
Author: Patrick Ziegler <ziegler.patrick@hotmail.de>
Date: Sat Mar 25 12:33:08 2023 +0100
Repair & Execute Nebula Tests
The Nebula tests attempt to fetch the Nebula jars from a non-existent
plugin. Afaik, this plugin has never been under version control.
Instead, add the Nebula update sites to the target platform and load the
plugins from there.
The CTableTree tests have been disabled, as this widget has been
archived back in 2009 and is not included in the Nebula releases,
meaning there is no way to test it. See Bug 162138 for reference.
commit 282a281a2550307abec11033af44e40b43d460ed
Author: Patrick Ziegler <ziegler.patrick@hotmail.de>
Date: Sat Mar 25 17:22:54 2023 +0100
Execute previously disabled JUnit Tests.
Currently, only the Common and Editor test suites are executed as part
of the Tycho build. This change also activates the following modules:
- Draw2D
- GEF
- SWT
- Core
- Swing
- RCP
The test suites of the main features are executed separately instead of
calling the WindowBuilderSuite, due to Out-Of-Memory problems on the
build nodes, when executed large test suites.
In order to instantiate the OSSupport class during the test, the
platform-specific fragments have to be added to the class path of the
test fragment. Because the fragments can't be added directly, they have
to be wrapped inside a feature.
Following tests have been disabled:
ConstructorChildAssociationTest#test_delete_noDelete_withGenerics
BindingsTest#test_DesignerMethodBinding_removeParameterType_whenGenerics
ViewPartGefTest#test_withMenuManager
SelectionToolCursorTest#test_ResizeTracker_Resize
EditableSupportTest#test_renameConflict_cancel
EditableSupportTest#test_renameConflict_keep
EditableSupportTest#test_renameConflict_useSourceValue
SwtAwtTest#test_parseWhenZeroSize
TableGefTest#test_canvas_MOVE_column
ChooseComponentEntryInfoTest#test_createTool_inProject_butNotInClassLoader
commit 3b9a81b9679e0583045ad9e19cfe802fd9dd8588
Author: Patrick Ziegler <ziegler.patrick@hotmail.de>
Date: Thu Mar 23 16:53:21 2023 +0100
Upload test results, even on test failures.
Currently, the build job is aborted when at least one test has failed.
As a result, none of the test results are uploaded to GitHub, and the
developer has to either manually dig through the build log or retest
them manually. With this change, the Maven build will ignore test
failures and
Patrick plans to migrate the embedded / copied draw2d code base to new updated and maintained GEF-Classic which would use in WB allow to profit from fixes in GEF.
Also worth noting is that Patrick is the first person contributing / working on WB since June 2022. So while the number of his contribution is currently still low, I nominate him based on his business experience and willingness to help with WB.
Please join me in welcoming Patrick.
Voter | Vote | Comments |
---|---|---|
Lars Vogel | +1 | +1 implied by nomination |
Laurent CARON | +1 | It's a pleasure to have Patrick as a commiter |
Wim Jongman | +1 | To the Batmobile, let's go! |
PMC Approval
- Aleksandar Kurtakov (+1) Welcome!