Nominee
Project
Role Type
Criteria
I'd like to nominate Igor Vinokur to become Eclipse Theia committer.
Igor has started his contributions to Eclipse Theia project almost one year ago
and he has already contributed a lot on the plugin extensibility system
and introduced other nice enhancements to the project.
Full list of Igor's contributions:
https://github.com/theia-ide/theia/pulls?q=is%3Apr+author%3Avinokurig+i…
The most significant ones:
- SCM Plugin API
https://github.com/theia-ide/theia/pull/4279
- Preference UI editor
https://github.com/theia-ide/theia/pull/1983
- window.withProgress Plugin API
https://github.com/theia-ide/theia/pull/2979
- Search functionality for the tree widget
https://github.com/theia-ide/theia/pull/2809
Nominated by
Date
-
Status
This election has been approved by the PMC.
| Voter | Vote | Comments |
|---|---|---|
| Artem Zatsarynnyi | +1 | +1 implied by nomination |
| Yevhen Vydolob | +1 | |
| Liang Huang | +1 | |
| Jacques Bouthillier | +1 | Welcome |
| Vincent Fugnitto | +1 | |
| Gorkem Ercan | +1 | |
| Anton Kosiakov | 0 | I really would like to accept everybody and appreciate an effort, but Igor's contributions were of low quality: (1) lost a lot of changes to git extension from other contributors for last 3 years: (a) some unintentionally by not being able properly rebase changes; (b) some intentionally by not being able to generalize abstractions properly. (2) Never brought up removed functionality himself, was only found by testing or in end products which is very costly. (3) Broke the git integration for 0.7.0 release by merging a PR without addressing comments from all reviewers (a lot of time spent on undoing harm and it is still not finished) (4) was not able to design clean data structures and control flows leading to race conditions and bugs (5) wasted a lot of time of code reviewers by negligence to testing and requirements. if you are going to keep contributing you are better be more diligent and take smaller tasks, leave arch refactorings. In this way there is a chance to learn and iterate. |
PMC Approval
- Martin Lippert (+1) Welcome!